Deprecate use of components - SortableGroup, SortableItem and SortableHandle #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
force-pushed
the
sn/deprecate-components
branch
2 times, most recently
from
0a84375 to
82ef0c8
Compare
|
@cah-briangantzler You ok with this PR? |
cah-brian-gantzler
approved these changes
Oct 26, 2021
|
Yea I approved it |
snewcomer
changed the title
snewcomer
force-pushed
the
sn/deprecate-components
branch
from
82ef0c8 to
dcccfb7
Compare
snewcomer
force-pushed
the
sn/deprecate-components
branch
from
dcccfb7 to
ffbd488
Compare
kiwiupover
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #377
Description
Proposal to remove the existing components in favour of the modifier versions in the next major version release. The components are classic ember component and does not allow for much flexibility the the layout of the dom. The element modifiers on the other hand does not care about your markup, you can attach them to any DOM node you want.
On top of that, the modifier versions don't require you to pass in the model so their api is a bit simpler.